linux-kernel - Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7sy7C6zp3giR+ypFXqbsNY_C3ggUgegS1zEWOAybkRBtCn4w@mail.gmail.com>
Date:   Thu, 16 Mar 2017 12:41:18 +0530
From:   "Jayachandran C." <c.jayachandran@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Aleksey Makarov <aleksey.makarov@...aro.org>,
        linux-serial@...r.kernel.org,
        Peter Hurley <peter@...leysoftware.com>,
        Jiri Slaby <jslaby@...e.com>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, Robin Murphy <robin.murphy@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching
 pl011 console"

Hi Greg,

On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@....com> wrote:
>
>
> On 01/03/17 15:23, Aleksey Makarov wrote:
>> The original patch makes the condition always true, so it is wrong.
>>
>> It masks (but not fixes) the bug described in the commit message
>> but introduces a regression (no console is selected by SPCR)
>> in regular (no 'console=ttyAMA') case.
>>
>> s/||/&&/ would not fix the problem as the root cause was identified
>> incorrectly.
>>
>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
>>
>
> Sorry for that, I will test your patches and respond to that. For this
> patch:
>
> Acked-by: Sudeep Holla <sudeep.holla@....com>
>

This fixes a regression I see in v4.11-rc2

Tested-by: Jayachandran C <jnair@...iumnetworks.com>

I don't see it in the tty/serial tree yet

JC.