linux-kernel - Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <008d062d-1095-5a65-3a69-33bee1f648d7@gmail.com>
Date:   Thu, 16 Mar 2017 12:31:53 +0300
From:   Aleksey Makarov <amakarov.linux@...il.com>
To:     "Jayachandran C." <c.jayachandran@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Aleksey Makarov <aleksey.makarov@...aro.org>,
        linux-serial@...r.kernel.org,
        Peter Hurley <peter@...leysoftware.com>,
        Jiri Slaby <jslaby@...e.com>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, Robin Murphy <robin.murphy@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching
 pl011 console"



On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> Hi Greg,
> 
> On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@....com> wrote:
>>
>>
>> On 01/03/17 15:23, Aleksey Makarov wrote:
>>> The original patch makes the condition always true, so it is wrong.
>>>
>>> It masks (but not fixes) the bug described in the commit message
>>> but introduces a regression (no console is selected by SPCR)
>>> in regular (no 'console=ttyAMA') case.
>>>
>>> s/||/&&/ would not fix the problem as the root cause was identified
>>> incorrectly.
>>>
>>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
>>>
>>
>> Sorry for that, I will test your patches and respond to that. For this
>> patch:
>>
>> Acked-by: Sudeep Holla <sudeep.holla@....com>
>>
> 
> This fixes a regression I see in v4.11-rc2
> 
> Tested-by: Jayachandran C <jnair@...iumnetworks.com>
> 
> I don't see it in the tty/serial tree yet

It's commit 713b93f1b849 from tty-next branch of 
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git

So it looks like it is scheduled for 4.12

Greg, this is a fix for regression.  Can it be applied to 4.11-rcX?

Thank you
Aleksey Makarov

> 
> JC.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>