linux-kernel - Re: [1/2] coresight: Disable the path only when the source is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47520af0-9837-fadc-9657-eced36633325@arm.com>
Date:   Tue, 14 Mar 2017 17:39:49 +0000
From:   Suzuki K Poulose <Suzuki.Poulose@....com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     Chunyan Zhang <zhang.chunyan@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [1/2] coresight: Disable the path only when the source is
 disabled

On 14/03/17 17:37, Mathieu Poirier wrote:
> Hi Suzuki,
>
> On 14 March 2017 at 11:31, Mathieu Poirier <mathieu.poirier@...aro.org> wrote:
>> From: "Suzuki K. Poulose" <Suzuki.Poulose@....com>
>>
>> With a coresight tracing session, the components along the path
>> from the source to sink are disabled after the source is disabled.
>> However, if the source was not actually disabled due to active
>> users, we should not disable the components in the path.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
>> ---
>>  drivers/hwtracing/coresight/coresight.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
>> index 0c37356..34cd1ed 100644
>> --- a/drivers/hwtracing/coresight/coresight.c
>> +++ b/drivers/hwtracing/coresight/coresight.c
>> @@ -253,7 +253,8 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode)
>>         return 0;
>>  }
>>
>> -static void coresight_disable_source(struct coresight_device *csdev)
>> +/* coresight_disable_source: Returns true if the device has been disabled */
>
> To be coherent with the rest of the file please use:
>
> /*
>  * coresight_disable_source: Returns true if the device has been disabled
>  */
>
> I would have done the modification myself but 2/2 needs tending as well.
>
Ah, sorry about that, will resend it. Thanks for spotting.

Suzuki