linux-kernel - [PATCH] PCI: aardvark: Remove msi-controller dt node probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170314190851.28203-1-stephen.boyd@linaro.org>
Date:   Tue, 14 Mar 2017 12:08:51 -0700
From:   Stephen Boyd <stephen.boyd@...aro.org>
To:     Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Subject: [PATCH] PCI: aardvark: Remove msi-controller dt node probing

This code assigns variables that are never used. Remove them.

Reported-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Signed-off-by: Stephen Boyd <stephen.boyd@...aro.org>
---
 drivers/pci/host/pci-aardvark.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
index 4fce494271cc..56e1aead65fc 100644
--- a/drivers/pci/host/pci-aardvark.c
+++ b/drivers/pci/host/pci-aardvark.c
@@ -917,8 +917,6 @@ static int advk_pcie_probe(struct platform_device *pdev)
 	struct advk_pcie *pcie;
 	struct resource *res;
 	struct pci_bus *bus, *child;
-	struct msi_controller *msi;
-	struct device_node *msi_node;
 	int ret, irq;
 
 	pcie = devm_kzalloc(dev, sizeof(struct advk_pcie), GFP_KERNEL);
@@ -962,12 +960,6 @@ static int advk_pcie_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	msi_node = of_parse_phandle(dev->of_node, "msi-parent", 0);
-	if (msi_node)
-		msi = of_pci_find_msi_chip_by_node(msi_node);
-	else
-		msi = NULL;
-
 	bus = pci_scan_root_bus_msi(dev, 0, &advk_pcie_ops,
 				    pcie, &pcie->resources, &pcie->msi);
 	if (!bus) {
-- 
2.10.0.297.gf6727b0