linux-kernel - Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2017 13:24:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     sunil.m@...hveda.org
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, karthiknishu@...oo.com
Subject: Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

On Wed, Mar 15, 2017 at 03:21:54PM +0530, sunil.m@...hveda.org wrote:
> @@ -2294,17 +2294,20 @@ static int _rtl92e_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
>  
>  		if (ipw->cmd == IEEE_CMD_SET_ENCRYPTION) {
>  			if (ipw->u.crypt.set_tx) {
> -				if (strcmp(ipw->u.crypt.alg, "CCMP") == 0)
> +				if (strcmp(ipw->u.crypt.alg, "CCMP") == 0) {
>  					ieee->pairwise_key_type = KEY_TYPE_CCMP;
> -				else if (strcmp(ipw->u.crypt.alg, "TKIP") == 0)
> +				} else if (strcmp(ipw->u.crypt.alg,
> +								"TKIP") == 0) {

This is higgledy piggledy.  The original was better.

regards,
dan carpenter