linux-kernel - Re: [PATCH v3 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315101628.GA4136@mwanda>
Date:   Wed, 15 Mar 2017 13:16:28 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     sunil.m@...hveda.org
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        karthiknishu@...oo.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/8] staging: rtl8192e: Remove unnecessary 'out of
 memory' message

On Wed, Mar 15, 2017 at 03:21:52PM +0530, sunil.m@...hveda.org wrote:
> From: Suniel Mahesh <sunil.m@...hveda.org>
> 
> Fixed the following checkpatch.pl warning:
> Possible unnecessary 'out of memory' message
> 
> Signed-off-by: Suniel Mahesh <sunil.m@...hveda.org>
> ---
> Changes for v3:
> 
> - Split earlier patches into multiple commits for easy review
>   as suggested by Greg K-H
> - Modified subject and description for better readability
> - Rebased on top of next-20170310
> - Patches were tested and built on next-20170310 and staging-testing
>   as suggested by Greg K-H, no errors reported
> 
> Changes for v2:
> 
> - Improve error handling reported by checkpatch.pl in rtl_core.c
> - new patch addition to the series
> - Rebased on top of next-20170306
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> index eb2321c..37a03ca 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> @@ -971,8 +971,8 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
>  
>  	priv->pFirmware = vzalloc(sizeof(struct rt_firmware));
>  	if (!priv->pFirmware)
> -		netdev_err(dev,
> -			   "rtl8192e: Unable to allocate space for firmware\n");
> +		return;

The patch description doesn't mention this return.

regards,
dan carpenter