linux-kernel - Re: [PATCH v4 0/5] perf report: Show inline stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2017 13:59:55 +0100
From:   Milian Wolff <milian.wolff@...b.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com
Subject: Re: [PATCH v4 0/5] perf report: Show inline stack

On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
> v4: Remove the options "--inline-line" and "--inline-name". Just use
>     a new option "--inline" to print the inline function information.
>     The policy is if the inline function name can be resolved then
>     print the name in priority. If the name can't be resolved, then
>     print the source line number.

This is still wrong from a usability POV. I may want to see the file/line for 
entry that have a name. And actually, there are afaik no situations where you 
could have a file/line but not a symbol name.

Again, why don't you align this with the other non-inlined frames, and honor 
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).

Bye
-- 
Milian Wolff | milian.wolff@...b.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts