linux-kernel - RE: [PATCH 6/7] megasas: Remove expensive inline from megasas_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c719ad070ccc72bd33e31b9f461c110d@mail.gmail.com>
Date:   Wed, 15 Mar 2017 17:47:00 +0530
From:   Sumit Saxena <sumit.saxena@...adcom.com>
To:     Andi Kleen <andi@...stfloor.org>, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>
Subject: RE: [PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd

>-----Original Message-----
>From: megaraidlinux.pdl@...adcom.com
>[mailto:megaraidlinux.pdl@...adcom.com] On Behalf Of Andi Kleen
>Sent: Wednesday, March 15, 2017 7:45 AM
>To: akpm@...ux-foundation.org
>Cc: linux-kernel@...r.kernel.org; Andi Kleen;
>megaraidlinux.pdl@...adcom.com
>Subject: [PATCH 6/7] megasas: Remove expensive inline from
>megasas_return_cmd
>
>From: Andi Kleen <ak@...ux.intel.com>
>
>Remove an inline from a fairly big function that is used often.
>It's unlikely that calling or not calling it makes a lot of difference.
>
>Saves around 8k text in my kernel.
>
>   text    data     bss     dec     hex filename
>9047801 5367568 11116544        25531913        1859609
>vmlinux-before-megasas
>9039417 5367568 11116544        25523529        1857549 vmlinux-megasas
>
>Cc: megaraidlinux.pdl@...adcom.com
>Signed-off-by: Andi Kleen <ak@...ux.intel.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 7ac9a9ee9bd4..55b71de3fb1f 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(struct
>megasas_instance
>  * @instance:		Adapter soft state
>  * @cmd:		Command packet to be returned to free command pool
>  */
>-inline void
>+void
> megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd
>*cmd)  {
> 	unsigned long flags;

Acked-by: Sumit Saxena <sumit.saxena@...adcom.com>

>--
>2.9.3
>