linux-kernel - Re: [PATCH 4/4] eeprom: at24: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 09:28:16 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH 4/4] eeprom: at24: Add OF device ID table

Hello Andy,

On 03/15/2017 07:43 PM, Andy Shevchenko wrote:
> On Wed, Mar 15, 2017 at 1:39 PM, Javier Martinez Canillas
> <javier@....samsung.com> wrote:
>> Hello Andy,
>>
>> On 03/15/2017 08:21 AM, Andy Shevchenko wrote:
>>> On Wed, Mar 15, 2017 at 12:58 PM, Javier Martinez Canillas
>>> <javier@....samsung.com> wrote:
>>>> On 03/15/2017 04:58 AM, Wolfram Sang wrote:
>>>
>>>> Unfortunately some maintainers do and don't accept patches adding I2C tables
>>>> only to have module autoloading working so I still think it should be fixed.
>>>
>>> Wait, how does it work for now?!
> 
>> It only works if you have an I2C device ID table, but that may not be the case
>> for DT-only drivers that could only have an OF device ID table. In the latter
>> case module autoload won't work.
> 
> OK.
> 
>>> Sounds for me you are trying to solve non-existing issue.
> 
>> It's an existing issue. You _must_ have an I2C device ID table if you want to
>> autload a device driver which is superfluous for DT-only drivers.
> 
> Okay, can you scope only affected drivers then? Looking to spread
> patches from you over all drivers I dunno they are all affected right
> now.
>

That's what I did. I've only posted patches for drivers that have DT support
but don't have an OF device ID table since module autoload will be broken for
those if the I2C core is fixed to report a proper OF modalias.

And drivers/misc/eeprom/at24.c is one of those drivers.
 
> P.S. Personally I agree with maintainers who do *not* apply this. Sorry.
> 

So what's your suggestion to solve the issue then? When I said that some
maintainers don't want a superfluous device table to be added I was talking
about I2C device ID table for DT-only drivers, but $SUBJECT is the opposite.

I've the impression that you are nacking $SUBJECT without fully understanding
what the problem is and how this patch + the patch for I2C core are fixing it.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America