linux-kernel - Re: [patch 7/7] x86/pci/mmcfg: Switch to ECAM config mode if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2017 07:15:21 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andi Kleen <ak@...ux.intel.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>, x86@...nel.org,
        Peter Anvin <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [patch 7/7] x86/pci/mmcfg: Switch to ECAM config mode if
 possible

On Thu, 16 Mar 2017, Andi Kleen wrote:

> > +	/*
> > +	 * The pointer to root_pci_ops has been handed in to ACPI already
> > +	 * and is already set in the busses.
> > +	 *
> > +	 * Switch the functions over to ECAM for all config space accesses.
> > +	 */
> > +	pci_root_ops.read = pci_ecam_read;
> > +	pci_root_ops.write = pci_ecam_write;
> > +	pr_info("PCI: Switch to ECAM configuration mode\n");
> 
> That patch is fine, but it's generally called MMCONFIG (don't know
> where this ECAM term comes from).

ECAM is the official name for the memory mapped configuration mechanism
according to the PCI express specification.

> So please use MMCONFIG or MCFG everywhere, not ECAM.

While I prefer using names which match specifications, I let Bjorn decide
on that one.

Thanks,

	tglx