linux-kernel - Re: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2017 15:16:59 +0900
From:   Greg KH <gregkh@...uxfoundation.org>
To:     sunil.m@...hveda.org
Cc:     dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
        karthiknishu@...oo.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and
 checks

On Fri, Mar 17, 2017 at 03:42:15AM +0530, sunil.m@...hveda.org wrote:
> From: Suniel Mahesh <sunil.m@...hveda.org>
> 
> Split earlier patches into multiple commits for easy review as
> suggested by Dan Carpenter.
> Modified subject, description and in few patches both for
> better readability as suggested by Greg KH.
> Dropped two patches from the earler series, as they were not adding 
> significant value, suggested by Dan Carpenter.
> Fixed the following issues reported by checkpatch.pl:
> Block comments should align the * on each line, aligned.
> Block comments use * on subsequent lines, other characters
> are replaced by * .
> Removed unnecessary 'out of memory' message.
> Comparison's to NULL could be written '!foo' or 'foo', modified.
> Replaced sizeof(struct foo) into sizeof(*ptr).
> Spaces preferred around that 'operator', spacing provided.
> Logical continuations should be on the previous line, modified accordingly.
> Unnecessary parentheses around variables, removed.
> Please use a blank line after function/struct/union/enum declarations, used.
> Blank lines aren't necessary after an open brace '{' and before a
> close brace '}', removed.
> No space is necessary after a cast, removed.
> Please don't use multiple blank lines, removed.

I have no idea what all of this means :(

Can you resend the full series, not just random patches in a series?  I
don't have any of the old ones anymore.

If I have applied other patches, just send this as a sequence that is
numbered properly, with all of the patches to be applied.

You need to make it very easy for a maintainer to know what to do here,
remember, we have no short-term memory of any previous submissions.

thanks,

greg k-h