linux-kernel - Re: [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2017 15:28:06 +0530
From:   Suniel Mahesh <suniel.spartan@...il.com>
To:     sunil.m@...hveda.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument
 to sizeof() instead of struct

On Friday 10 March 2017 12:20 AM, sunil.m@...hveda.org wrote:
> From: Suniel Mahesh <sunil.m@...hveda.org>
>
> Prefer vzalloc(sizeof(*priv->pFirmware)...) over
> vzalloc(sizeof(struct rt_firmware)...) as reported by checkpatch.pl
>
> Signed-off-by: Suniel Mahesh <sunil.m@...hveda.org>
> ---
> Changes for v2:
>
> - new patch addition to the series
> - Rebased on top of next-20170306
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> index fb711d2..a099bce 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> @@ -965,7 +965,7 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
>
>  	priv->card_type = PCI;
>
> -	priv->pFirmware = vzalloc(sizeof(struct rt_firmware));
> +	priv->pFirmware = vzalloc(sizeof(*priv->pFirmware));
>  	if (!priv->pFirmware)
>  		return -ENOMEM;
>  	skb_queue_head_init(&priv->skb_queue);
>
ok