linux-kernel - Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v65m8JszJWjJs+ja66RVXeHpytSKNX61D2vf1Yp=kWCWFA@mail.gmail.com>
Date:   Mon, 20 Mar 2017 16:32:45 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        mo.ucina@...il.com, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Chen-Yu Tsai <wens@...e.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings

Hi,

On Mon, Mar 20, 2017 at 4:29 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> Hi Florian,
>
> On Sat, Mar 18, 2017 at 09:53:20PM -0700, Florian Fainelli wrote:
>> The CPU port of the BCM53125 is configured with RGMII (no delays) but
>> this should actually be RGMII with transmit delay (rgmii-txid) because
>> STMMAC takes care of inserting the transmitter delay. This fixes
>> occasional packet loss encountered.
>>
>> Fixes: d7b9eaff5f0c ("ARM: dts: sun7i: Add BCM53125 switch nodes to the lamobo-r1 board")
>> Reported-by: Hartmut Knaack <knaack.h@....de>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>
> Applied, thanks!
> Maxime

I'm not sure dwmac-sunxi supports "rgmii-txid" though.
At least I don't remember implementing it.

ChenYu