linux-kernel - Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMty3ZC=mS6L8ajEnZDPJsvMvOH0NF5MBHdc+MYofBXBfe9JXg@mail.gmail.com>
Date:   Mon, 20 Mar 2017 11:55:27 +0530
From:   Jagan Teki <jagan@...rulasolutions.com>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Jagan Teki <jagan@...nedev.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Matteo Lisi <matteo.lisi@...icam.com>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

On Mon, Mar 20, 2017 at 8:06 AM, Shawn Guo <shawnguo@...nel.org> wrote:
> On Thu, Mar 16, 2017 at 12:35:38PM +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@...rulasolutions.com>
>>
>> Add missing documentation of max11801-ts dt-binding details.
>>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: Shawn Guo <shawnguo@...nel.org>
>> Cc: Michael Trimarchi <michael@...rulasolutions.com>
>> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
>> ---
>> Changes for v6:
>> - Replace the lable and name of the node
>>    ts: max11801 => max11801: touchscreen@48
>> Changes for v5:
>> - Newly added patch
>>
>>  .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>> new file mode 100644
>> index 0000000..4afccbe
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>> @@ -0,0 +1,18 @@
>> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
>> +
>> +Required properties:
>> +- compatible: must be "max11801"
>
> Shouldn't it have a vendor prefix?

Drivers i2c_device_id.name doesn't have vendor prefix, should I fix
that one as well?

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.