linux-kernel - Re: [PATCH v2 6/9] clk: meson: gxbb: mpll: use rw operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <149013840504.54062.12985141705597897606@resonance>
Date:   Tue, 21 Mar 2017 16:20:05 -0700
From:   Michael Turquette <mturquette@...libre.com>
To:     Jerome Brunet <jbrunet@...libre.com>,
        "Stephen Boyd" <sboyd@...eaurora.org>,
        "Kevin Hilman" <khilman@...libre.com>,
        "Carlo Caione" <carlo@...one.org>
Cc:     "Jerome Brunet" <jbrunet@...libre.com>, linux-clk@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/9] clk: meson: gxbb: mpll: use rw operation

Quoting Jerome Brunet (2017-03-09 02:41:51)
> Use read/write operations for the mpll clocks instead of the
> read-only ones.
> 
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Looks good to me.

Regards,
Mike

> ---
>  drivers/clk/meson/gxbb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 79fb8989f8dd..5059c7bbdbb3 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -459,7 +459,7 @@ static struct meson_clk_mpll gxbb_mpll0 = {
>         .lock = &clk_lock,
>         .hw.init = &(struct clk_init_data){
>                 .name = "mpll0",
> -               .ops = &meson_clk_mpll_ro_ops,
> +               .ops = &meson_clk_mpll_ops,
>                 .parent_names = (const char *[]){ "fixed_pll" },
>                 .num_parents = 1,
>         },
> @@ -489,7 +489,7 @@ static struct meson_clk_mpll gxbb_mpll1 = {
>         .lock = &clk_lock,
>         .hw.init = &(struct clk_init_data){
>                 .name = "mpll1",
> -               .ops = &meson_clk_mpll_ro_ops,
> +               .ops = &meson_clk_mpll_ops,
>                 .parent_names = (const char *[]){ "fixed_pll" },
>                 .num_parents = 1,
>         },
> @@ -519,7 +519,7 @@ static struct meson_clk_mpll gxbb_mpll2 = {
>         .lock = &clk_lock,
>         .hw.init = &(struct clk_init_data){
>                 .name = "mpll2",
> -               .ops = &meson_clk_mpll_ro_ops,
> +               .ops = &meson_clk_mpll_ops,
>                 .parent_names = (const char *[]){ "fixed_pll" },
>                 .num_parents = 1,
>         },
> -- 
> 2.9.3
>