linux-kernel - Re: [PATCH] ipmi: bt-bmc: Add ast2500 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5f74faa-e5a2-e13d-01f0-6ae732f07c80@kaod.org>
Date:   Wed, 22 Mar 2017 15:09:33 +0100
From:   Cédric Le Goater <clg@...d.org>
To:     Joel Stanley <joel@....id.au>, Corey Minyard <minyard@....org>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Andrew Jeffery <andrew@...id.au>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] ipmi: bt-bmc: Add ast2500 compatible string

On 03/22/2017 03:01 PM, Joel Stanley wrote:
> The ast2500 SoCs contain the same IPMI BT device.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>

Reviewed-by: Cédric Le Goater <clg@...d.org>

Thanks,

C. 


> ---
>  Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 4 +++-
>  drivers/char/ipmi/bt-bmc.c                                        | 1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> index 6f28969af9dc..028268fd99ee 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> @@ -6,7 +6,9 @@ perform in-band IPMI communication with their host.
>  
>  Required properties:
>  
> -- compatible : should be "aspeed,ast2400-ibt-bmc"
> +- compatible : should be one of
> +	"aspeed,ast2400-ibt-bmc"
> +	"aspeed,ast2500-ibt-bmc"
>  - reg: physical address and size of the registers
>  
>  Optional properties:
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index fc9e8891eae3..002907e6c7d9 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -485,6 +485,7 @@ static int bt_bmc_remove(struct platform_device *pdev)
>  
>  static const struct of_device_id bt_bmc_match[] = {
>  	{ .compatible = "aspeed,ast2400-ibt-bmc" },
> +	{ .compatible = "aspeed,ast2500-ibt-bmc" },
>  	{ },
>  };
>  
>