linux-kernel - Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170322153208.GC25645@e104818-lin.cambridge.arm.com>
Date:   Wed, 22 Mar 2017 15:32:09 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Will Deacon <will.deacon@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG

On Wed, Mar 22, 2017 at 03:51:54PM +0100, Arnd Bergmann wrote:
> On Wed, Mar 22, 2017 at 3:37 PM, Catalin Marinas
> <catalin.marinas@....com> wrote:
> > Hi Arnd,
> >
> > On Tue, Mar 14, 2017 at 10:39:21PM +0100, Arnd Bergmann wrote:
> >> This mirrors commit e9c38ceba8d9 ("ARM: 8455/1: define __BUG as
> >> asm(BUG_INSTR) without CONFIG_BUG") to make the behavior of
> >> arm64 consistent with arm and x86, and avoids lots of warnings in
> >> randconfig builds, such as:
> >>
> >> kernel/seccomp.c: In function '__seccomp_filter':
> >> kernel/seccomp.c:666:1: error: no return statement in function returning non-void [-Werror=return-type]
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >
> > A side-effect of this patch is that it turns WARN into BUG. I hit the
> > WARN_ONCE in arch/arm64/kernel/efi.c:34 (on Juno with 64K pages) and
> > with your patch applied, the kernel panics.
> 
> Taht was certainly not intended, and I don't see yet what exactly is going on.
> What is your setting for CONFIG_BUG and CONFIG_BUGVERBOSE?

CONFIG_BUG=y
CONFIG_DEBUG_BUGVERBOSE=y

(just defconfig + 64K pages)

-- 
Catalin