linux-kernel - Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1V37QGtB6EeXptaOgKFz1QE=VObN91r1Ld-0ZOKAPXaQ@mail.gmail.com>
Date:   Wed, 22 Mar 2017 17:29:19 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Will Deacon <will.deacon@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG

On Wed, Mar 22, 2017 at 4:32 PM, Catalin Marinas
<catalin.marinas@....com> wrote:
> On Wed, Mar 22, 2017 at 03:51:54PM +0100, Arnd Bergmann wrote:
>> On Wed, Mar 22, 2017 at 3:37 PM, Catalin Marinas
>> <catalin.marinas@....com> wrote:

>> Taht was certainly not intended, and I don't see yet what exactly is going on.
>> What is your setting for CONFIG_BUG and CONFIG_BUGVERBOSE?
>
> CONFIG_BUG=y
> CONFIG_DEBUG_BUGVERBOSE=y

Ok, I found the typo, can you just fold this in, or should I send an
updated patch?

 Arnd

diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h
index bfc6021760e5..ff030254f791 100644
--- a/arch/arm64/include/asm/bug.h
+++ b/arch/arm64/include/asm/bug.h
@@ -49,10 +49,10 @@ _BUGVERBOSE_LOCATION(__FILE__, __LINE__) \

 #define __BUG_FLAGS(flags) \
  asm volatile ( \
- __BUG_ENTRY(0) \
+ __BUG_ENTRY(flags) \
  "brk %[imm]" :: [imm] "i" (BUG_BRK_IMM) \
  );

 #define BUG() do { \
  __BUG_FLAGS(0); \
  unreachable(); \