linux-kernel - Re: [PATCH] qedf: fix wrong le16 conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170323.115630.1600544123792478571.davem@davemloft.net>
Date:   Thu, 23 Mar 2017 11:56:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     martin.petersen@...cle.com
Cc:     QLogic-Storage-Upstream@...ium.com, jejb@...ux.vnet.ibm.com,
        arnd@...db.de, Ram.Amrani@...ium.com, Chad.Dupuis@...ium.com,
        Tomer.Tayar@...ium.com, Yuval.Mintz@...ium.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qedf: fix wrong le16 conversion

From: "Martin K. Petersen" <martin.petersen@...cle.com>
Date: Thu, 23 Mar 2017 10:19:03 -0400

> Arnd Bergmann <arnd@...db.de> writes:
> 
>> gcc points out that we are converting a 16-bit integer into a 32-bit
>> little-endian type and assigning that to 16-bit little-endian
>> will end up with a zero:
>>
>> drivers/scsi/qedf/drv_fcoe_fw_funcs.c: In function 'init_initiator_rw_fcoe_task':
>> include/uapi/linux/byteorder/big_endian.h:32:26: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
>>   t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID);
>>
>> The correct solution appears to be to just use a 16-bit byte swap instead.
>>
>> Fixes: be086e7c53f1 ("qed*: Utilize Firmware 8.15.3.0")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Dave: Since you queued the firmware patch, mind taking this fix through
> your tree?

Ok, applied to net-next, thanks.