linux-kernel - Re: [PATCH V8 2/3] irq: Track the interrupt timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1703231503390.2304@knanqh.ubzr>
Date:   Thu, 23 Mar 2017 15:06:17 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
cc:     Peter Zijlstra <peterz@...radead.org>, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, rafael@...nel.org,
        vincent.guittot@...aro.org
Subject: Re: [PATCH V8 2/3] irq: Track the interrupt timings

On Thu, 23 Mar 2017, Daniel Lezcano wrote:

> On Thu, Mar 23, 2017 at 07:35:42PM +0100, Peter Zijlstra wrote:
> > On Thu, Mar 23, 2017 at 06:42:02PM +0100, Daniel Lezcano wrote:
> > > +void irq_timings_enable(void)
> > > +{
> > > +	static_branch_inc(&irq_timing_enabled);
> > 
> > Do you really need counting, or do you want static_branch_enable() here?
> 
> I put counting in order to let several subsystem to use the irq timings if it
> is needed.

Please avoid overengineering.  This can easily be changed later if it is 
needed.


Nicolas