linux-kernel - Re: [PATCH V8 2/3] irq: Track the interrupt timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1703231507260.2304@knanqh.ubzr>
Date:   Thu, 23 Mar 2017 15:14:22 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        peterz@...radead.org, rafael@...nel.org, vincent.guittot@...aro.org
Subject: Re: [PATCH V8 2/3] irq: Track the interrupt timings

On Thu, 23 Mar 2017, Daniel Lezcano wrote:

> +#define IRQ_TIMINGS_SHIFT	5
> +#define IRQ_TIMINGS_SIZE	(1 << IRQ_TIMINGS_SHIFT)
> +#define IRQ_TIMINGS_MASK	(IRQ_TIMINGS_SIZE - 1)
> +
> +struct irq_timing {
> +	u32 irq;
> +	u64 ts;
> +};
> +
> +struct irq_timings {
> +	struct irq_timing values[IRQ_TIMINGS_SIZE]; /* our circular buffer */

This is not very space efficient because of alignment restrictions from 
the u64 in struct irq_timing. 25% of the memory is wasted.

You could consider having two arrays instead:

	u32 irq_values[IRQ_TIMINGS_SIZE];
	u64 ts_values[IRQ_TIMINGS_SIZE];


Nicolas