linux-kernel - Re: [PATCH] aoe: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <786b1a47-ef74-4333-a1c3-f1c1dc4a1db9@acm.org>
Date:   Sat, 25 Mar 2017 15:32:08 -0400
From:   Ed Cashin <ed.cashin@....org>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aoe: use setup_timer

On 03/24/2017 10:15 AM, Geliang Tang wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  drivers/block/aoe/aoemain.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/aoe/aoemain.c b/drivers/block/aoe/aoemain.c
> index 4b987c2..20865d4 100644
> --- a/drivers/block/aoe/aoemain.c
> +++ b/drivers/block/aoe/aoemain.c
> @@ -28,10 +28,8 @@ discover_timer(ulong vp)
>
>  	switch (vp) {
>  	case TINIT:
> -		init_timer(&t);
> +		setup_timer(&t, discover_timer, TRUN);
>  		spin_lock_init(&lock);
> -		t.data = TRUN;
> -		t.function = discover_timer;
>  		die = 0;
>  	case TRUN:
>  		spin_lock_irqsave(&lock, flags);
>

This change looks OK to me, thanks.

-- 
   Ed