linux-kernel - Re: [PATCH] ipmi_ssif: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c8dfe9f-331a-92b2-9889-6b2a4f862bdc@acm.org>
Date:   Fri, 24 Mar 2017 21:59:39 -0500
From:   Corey Minyard <minyard@....org>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi_ssif: use setup_timer

A little nicer, yes.  In queue for the next release.

Thanks,

-corey

On 03/24/2017 09:15 AM, Geliang Tang wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>   drivers/char/ipmi/ipmi_ssif.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index cca6e5b..a92a049 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1642,9 +1642,8 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id)
>   
>   	spin_lock_init(&ssif_info->lock);
>   	ssif_info->ssif_state = SSIF_NORMAL;
> -	init_timer(&ssif_info->retry_timer);
> -	ssif_info->retry_timer.data = (unsigned long) ssif_info;
> -	ssif_info->retry_timer.function = retry_timeout;
> +	setup_timer(&ssif_info->retry_timer, retry_timeout,
> +		    (unsigned long)ssif_info);
>   
>   	for (i = 0; i < SSIF_NUM_STATS; i++)
>   		atomic_set(&ssif_info->stats[i], 0);