linux-kernel - Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78897278-9240-6794-e99b-f3ff3013304f@acm.org>
Date:   Fri, 24 Mar 2017 21:56:36 -0500
From:   Corey Minyard <minyard@....org>
To:     Sinan Kaya <okaya@...eaurora.org>, linux-acpi@...r.kernel.org,
        timur@...eaurora.org, sulrich@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

Oops, yes, this is an issue.

However, it should probably depend on IPMI_HANDLER, not the individual 
interface types.

-corey

On 03/23/2017 10:53 AM, Sinan Kaya wrote:
> ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver
> to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.
>
> IPMI_SSIF is an alternative BMC communication method. It allows BMC to be
> accessed over an I2C bus instead of a standard interface.
>
> Enabling ACPI_IPMI over IPMI_SSIF with this change.
>
> Signed-off-by: Sinan Kaya <okaya@...eaurora.org>
> ---
>   drivers/acpi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 83e5f7e..8767062 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -256,7 +256,7 @@ config ACPI_PROCESSOR
>   
>   config ACPI_IPMI
>   	tristate "IPMI"
> -	depends on IPMI_SI
> +	depends on IPMI_SI||IPMI_SSIF
>   	default n
>   	help
>   	  This driver enables the ACPI to access the BMC controller. And it