linux-kernel - Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOijeYKL792MCkx1hf3txDh+7PyY_ddEUzLUkugBHkUivbqRSA@mail.gmail.com>
Date:   Sun, 26 Mar 2017 20:55:35 +0800
From:   Bamvor Zhang <bamv2005@...il.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org,
        Bamvor Jian Zhang <bamvor.zhangjian@...wei.com>,
        Shuah Khan <shuah@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

Hi,

On Sat, Mar 25, 2017 at 12:18 AM, Darren Hart <dvhart@...radead.org> wrote:
>
> The use of $$OUTPUT in the target shell commands resulted in an empty
> string followed by an absolute path for which mkdir failed:
>
> $ make -C tools/testing/selftests/futex
> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
> Makefile:36: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> for DIR in functional; do               \
>         BUILD_TARGET=$OUTPUT/$DIR;      \
>         mkdir $BUILD_TARGET  -p;        \
>         make OUTPUT=$BUILD_TARGET -C $DIR all;\
> done
> mkdir: cannot create directory ‘/functional’: Permission denied
>
> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
> variable. The above make command now completes successfully.
Test with native and cross-compiler build from selftests/futex or selftests,
the results are good.
Tested-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>

Regards

Bamvor
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> Cc: linux-kselftest@...r.kernel.org
> Cc: bamvor.zhangjian@...wei.com
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: <stable@...r.kernel.org> # 4.10.x-
> ---
>  tools/testing/selftests/futex/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 653c5cd..c8095e6 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -8,7 +8,7 @@ include ../lib.mk
>
>  all:
>         for DIR in $(SUBDIRS); do               \
> -               BUILD_TARGET=$$OUTPUT/$$DIR;    \
> +               BUILD_TARGET=$(OUTPUT)/$$DIR;   \
>                 mkdir $$BUILD_TARGET  -p;       \
>                 make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>         done
> @@ -22,7 +22,7 @@ override define INSTALL_RULE
>         install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
>
>         @for SUBDIR in $(SUBDIRS); do \
> -               BUILD_TARGET=$$OUTPUT/$$SUBDIR; \
> +               BUILD_TARGET=$(OUTPUT)/$$SUBDIR;        \
>                 mkdir $$BUILD_TARGET  -p;       \
>                 $(MAKE) OUTPUT=$$BUILD_TARGET -C $$SUBDIR INSTALL_PATH=$(INSTALL_PATH)/$$SUBDIR install; \
>         done;
> @@ -34,7 +34,7 @@ endef
>
>  clean:
>         for DIR in $(SUBDIRS); do               \
> -               BUILD_TARGET=$$OUTPUT/$$DIR;    \
> +               BUILD_TARGET=$(OUTPUT)/$$DIR;   \
>                 mkdir $$BUILD_TARGET  -p;       \
>                 make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>         done
> --
> 2.9.3
>
>
> --
> Darren Hart
> VMware Open Source Technology Center




-- 
-----------------------------------------
   arm64, kernel. opensuse
   blog: http://aarch64.me
-----------------------------------------