linux-kernel - Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87efxi8d82.fsf@concordia.ellerman.id.au>
Date:   Tue, 28 Mar 2017 11:19:25 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Darren Hart <dvhart@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     linux-kselftest@...r.kernel.org, bamvor.zhangjian@...wei.com,
        Shuah Khan <shuah@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable

Darren Hart <dvhart@...radead.org> writes:

> The use of $$OUTPUT in the target shell commands resulted in an empty
> string followed by an absolute path for which mkdir failed:
>
> $ make -C tools/testing/selftests/futex
> make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex'
> Makefile:36: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> for DIR in functional; do		\
> 	BUILD_TARGET=$OUTPUT/$DIR;	\
> 	mkdir $BUILD_TARGET  -p;	\
> 	make OUTPUT=$BUILD_TARGET -C $DIR all;\
> done
> mkdir: cannot create directory ‘/functional’: Permission denied
>
> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT
> variable. The above make command now completes successfully.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> Cc: linux-kselftest@...r.kernel.org
> Cc: bamvor.zhangjian@...wei.com
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: <stable@...r.kernel.org> # 4.10.x-

The OUTPUT support only went into v4.11-rc1, so I don't see why you need
a stable tag?

Change looks good though.

cheers