linux-kernel - Re: [PATCH 1/2] selftests: fix the broken individual test for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bmsm8d2a.fsf@concordia.ellerman.id.au>
Date:   Tue, 28 Mar 2017 11:22:53 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
        luto@...capital.net, shuahkh@....samsung.com
Cc:     linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...nel.org, broonie@...nel.org,
        bamvor.zhangjian@...wei.com, bamvor.zhangjian@...aro.org
Subject: Re: [PATCH 1/2] selftests: fix the broken individual test for x86

Bamvor Jian Zhang <bamvor.zhangjian@...aro.org> writes:

> Andy Lutomirski report that build individual testcase in x86 is broken:
>
> $ make -C tools/testing/selftests/x86 ldt_gdt_32
> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86'
> Makefile:44: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> make: *** No rule to make target 'ldt_gdt_32'.  Stop.
> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86'
>
> This patch fix this issue by adding default OUTPUT and convert
> target in Makefile of x86.
>
> And also mention this use case in Documentation/kselftests.txt
>
> Reported-by: Andy Lutomirski <luto@...capital.net>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
> ---
>  Documentation/kselftest.txt          |  6 ++++++
>  tools/testing/selftests/x86/Makefile | 23 ++++++++++++++---------
>  2 files changed, 20 insertions(+), 9 deletions(-)

I don't think this is a good fix, it only fixes this one Makefile, and
it's quite verbose. But if it really bothers Andy then it would be OK as
a stop-gap for 4.11.

cheers