linux-kernel - Re: [PATCH] staging: speakup: fix warning for static declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170327075557.cw6bkjimxkew4wcq@var.youpi.perso.aquilenet.fr>
Date:   Mon, 27 Mar 2017 09:55:57 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     gregkh@...uxfoundation.org, w.d.hubbs@...il.com,
        chris@...-brannons.com, kirk@...sers.ca, okash.khawaja@...il.com,
        rvarsha016@...il.com, arushisinghal19971997@...il.com,
        shiva@...ev.nl, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: fix warning for static declaration

Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Yes, indeed.

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Thanks

> ---
>  drivers/staging/speakup/serialio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 5e31aca..3fab1c3 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
>  }
>  EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
>  
> -int spk_serial_out(struct spk_synth *in_synth, const char ch)
> +static int spk_serial_out(struct spk_synth *in_synth, const char ch)
>  {
>  	if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
>  		outb_p(ch, speakup_info.port_tts);
> -- 
> 2.5.0
> 

-- 
Samuel
 Je suis maintenant possesseur d'un ordinateur portable Compaq Armada
 1592DT avec port infra-rouge. Auriez-vous connaissance de programmes
 suceptibles d'utiliser ce port afin de servir de télécommande ?
 -+- JN in NPC : ben quoi, c'est pas à ça que ça sert ?