linux-kernel - Re: [PATCH] staging: speakup: fix warning for static declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170327075853.tmldwny6ih2f4vno@var.youpi.perso.aquilenet.fr>
Date:   Mon, 27 Mar 2017 09:58:53 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Okash Khawaja <okash.khawaja@...il.com>
Cc:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        gregkh@...uxfoundation.org, w.d.hubbs@...il.com,
        chris@...-brannons.com, kirk@...sers.ca, rvarsha016@...il.com,
        arushisinghal19971997@...il.com, shiva@...ev.nl,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: fix warning for static declaration

Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> Thanks for this :) Could you also move the function higher in the same
> file - above line 139 where all static functions are defined?

I'd say no need for this. spk_serial_in is just above.  Moving functions
just for the sake of static vs non-static does not make the code more
readable to my eyes :)
(and it makes tracking changes harder in git annotate)

Samuel