lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f82705b0-1727-ef4a-138c-e268f3530f07@6wind.com>
Date:   Mon, 27 Mar 2017 11:45:17 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Michal Marek <mmarek@...e.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>, bp@...en8.de,
        slash.tmp@...e.fr, Daniel Vetter <daniel.vetter@...ll.ch>,
        rmk+kernel@...linux.org.uk, msalter@...hat.com, jengelh@...i.de,
        hch@...radead.org, Tobias Klauser <tklauser@...tanz.ch>,
        mpe@...erman.id.au, Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland

Hi Masahiro,

Le 27/03/2017 à 07:53, Masahiro Yamada a écrit :
> Hi Nicolas,
> 
> 
> 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@...nd.com>:
[snip]
>> diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
>> index 6a261cb52d95..6a754ada59af 100644
>> --- a/include/uapi/linux/btrfs_tree.h
>> +++ b/include/uapi/linux/btrfs_tree.h
>> @@ -2,6 +2,7 @@
>>  #define _BTRFS_CTREE_H_
>>
>>  #include <linux/types.h>
>> +#include <linux/btrfs.h>
>>
> 
> Can you move <linux/types.h> below <linux/btrfs.h>
> to sort the includes alphabetically?
Ok.

> 
> This also applies to:
> 
> include/uapi/linux/qrtr.h in 06/11
> include/uapi/linux/cryptouser.h  in 08/11
Ok.


Regards,
Nicolas

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ