linux-kernel - Re: [PATCH v2] KVM: x86: cleanup the page tracking SRCU instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9d0a97b-a017-3319-6014-d876405ae2a8@gmail.com>
Date:   Tue, 28 Mar 2017 19:25:21 +0800
From:   Xiao Guangrong <xiaoguangrong.eric@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, dvyukov@...gle.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] KVM: x86: cleanup the page tracking SRCU instance



On 28/03/2017 5:40 PM, Paolo Bonzini wrote:

>  void kvm_page_track_init(struct kvm *kvm)
>  {
>  	struct kvm_page_track_notifier_head *head;
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 64697fe475c3..f2379673912a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -8070,6 +8070,7 @@ void kvm_arch_sync_events(struct kvm *kvm)
>  	cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work);
>  	kvm_free_all_assigned_devices(kvm);
>  	kvm_free_pit(kvm);
> +	kvm_page_track_cleanup(kvm);
>  }

Moving it to kvm_arch_destroy_vm() is better as the init
function is called in kvm_arch_init_vm().

Otherwise it looks great to me:
Reviewed-by: Xiao Guangrong <xiaoguangrong.eric@...il.com>

Thanks for the fix.