linux-kernel - Re: [PATCH v2] KVM: x86: cleanup the page tracking SRCU instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ff4d874-7bca-b4f8-6fdf-db415f06b84b@redhat.com>
Date:   Tue, 28 Mar 2017 14:06:25 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Xiao Guangrong <xiaoguangrong.eric@...il.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, dvyukov@...gle.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] KVM: x86: cleanup the page tracking SRCU instance



On 28/03/2017 13:25, Xiao Guangrong wrote:
> 
> 
> On 28/03/2017 5:40 PM, Paolo Bonzini wrote:
> 
>>  void kvm_page_track_init(struct kvm *kvm)
>>  {
>>      struct kvm_page_track_notifier_head *head;
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 64697fe475c3..f2379673912a 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -8070,6 +8070,7 @@ void kvm_arch_sync_events(struct kvm *kvm)
>>      cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work);
>>      kvm_free_all_assigned_devices(kvm);
>>      kvm_free_pit(kvm);
>> +    kvm_page_track_cleanup(kvm);
>>  }
> 
> Moving it to kvm_arch_destroy_vm() is better as the init
> function is called in kvm_arch_init_vm().

That's fine too, thanks!.

Paolo

> Otherwise it looks great to me:
> Reviewed-by: Xiao Guangrong <xiaoguangrong.eric@...il.com>
> 
> Thanks for the fix.