linux-kernel - Re: [PATCH] 6lowpan: set peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACumGO+QvuyDg21yogaUn1WCHv2S3=_DXD+My0Q6ANYE1NYKzg@mail.gmail.com>
Date:   Tue, 28 Mar 2017 16:42:50 +0300
From:   "Von Dentz, Luiz" <luiz.von.dentz@...el.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Stefan Schmidt <stefan@....samsung.com>,
        Jukka Rissanen <jukka.rissanen@...ux.intel.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Patrik Flykt <patrik.flykt@...ux.intel.com>,
        Alexander Aring <aar@...gutronix.de>,
        Glenn Ruben Bakke <glennrubenbakke@...dicsemi.no>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 6lowpan: set peer_addr correctly again

Hi Marcel,

On Tue, Mar 28, 2017 at 4:37 PM, Marcel Holtmann <marcel@...tmann.org> wrote:
> Hi Arnd,
>
>> A bugfix accidentally changed one line to return the peer_addr
>> from setup_header, causing it to become unused:
>>
>> net/bluetooth/6lowpan.c: In function 'setup_header':
>> net/bluetooth/6lowpan.c:402:14: error: parameter 'peer_addr' set but not used [-Werror=unused-but-set-parameter]
>>
>> The only user of the variable is a subsequent printk(), and
>> it is not otherwise initialized, so reverting the changed line
>> looks like the right fix.
>>
>> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>> net/bluetooth/6lowpan.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I took Colin’s patch since it showed up first in my inbox.

Thanks, I might be missing something since the error doesn't show up for me:

  CC [M]  net/bluetooth/6lowpan.o
  LD [M]  net/bluetooth/bluetooth_6lowpan.o