linux-kernel - Re: [PATCH] percpu: drop useless macro PER_CPU_DEF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170329152827.GB30385@htj.duckdns.org>
Date:   Wed, 29 Mar 2017 11:28:27 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Cao jin <caoj.fnst@...fujitsu.com>
Cc:     linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, cl@...ux.com
Subject: Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote:
> On 03/29/2017 12:00 AM, Tejun Heo wrote:
> > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
> >> Signed-off-by: Cao jin <caoj.fnst@...fujitsu.com>
> > 
> > I'm not sure.  I think I used it during development and it's not like
> > it costs anything to keep.
> 
> It easily confusing newbies without any comments for its purpose.

percpu variable handling is pretty complex to begin with.  I don't buy
that an empty default attribute macro adds anything noticeable there.

> Temporary using during development seems not good to persist. Could I
> know its purpose?

I don't remember the exact details but at the same time I don't see
the value of the proposed change.  We can apply or not apply the patch
and either way wouldn't make any noticeable difference.  What's the
point?

Thanks.

-- 
tejun