lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 11:28:41 -0400 From: Paul Moore <paul@...l-moore.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov, Eric Paris <eparis@...isplace.org>, James Morris <james.l.morris@...cle.com>, "Serge E. Hallyn" <serge@...lyn.com>, Stephen Smalley <sds@...ho.nsa.gov>, William Roberts <william.c.roberts@...el.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 33/46] selinux: Move an assignment for the variable "rc" in class_read() On Sun, Jan 15, 2017 at 10:33 AM, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Sun, 15 Jan 2017 11:10:39 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Dropped for reasons already discussed. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 3af2b0849495..9035e5329ceb 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1345,10 +1345,10 @@ static int class_read(struct policydb *p, struct hashtab *h, void *fp) > if (rc) > goto bad; > > - rc = -EINVAL; > cladatum->comdatum = hashtab_search(p->p_commons.table, cladatum->comkey); > if (!cladatum->comdatum) { > printk(KERN_ERR "SELinux: unknown common %s\n", cladatum->comkey); > + rc = -EINVAL; > goto bad; > } > } > -- > 2.11.0 > -- paul moore www.paul-moore.com
Powered by blists - more mailing lists