lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 11:30:17 -0400 From: Paul Moore <paul@...l-moore.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov, Eric Paris <eparis@...isplace.org>, James Morris <james.l.morris@...cle.com>, "Serge E. Hallyn" <serge@...lyn.com>, Stephen Smalley <sds@...ho.nsa.gov>, William Roberts <william.c.roberts@...el.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 34/46] selinux: Return directly after a failed kzalloc() in common_read() On Sun, Jan 15, 2017 at 10:34 AM, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Sun, 15 Jan 2017 11:15:19 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 9035e5329ceb..551685283399 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1150,10 +1150,9 @@ static int common_read(struct policydb *p, struct hashtab *h, void *fp) > u32 len, nel; > int i, rc; > > - rc = -ENOMEM; > comdatum = kzalloc(sizeof(*comdatum), GFP_KERNEL); > if (!comdatum) > - goto bad; > + return -ENOMEM; > > rc = next_entry(buf, fp, sizeof buf); > if (rc) > -- > 2.11.0 > -- paul moore www.paul-moore.com
Powered by blists - more mailing lists