lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 19:16:11 +0300 From: Daniel Baluta <daniel.baluta@...il.com> To: simran singhal <singhalsimran0@...il.com> Cc: Jonathan Cameron <jic23@...nel.org>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald <pmeerw@...erw.net>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, outreachy-kernel <outreachy-kernel@...glegroups.com> Subject: Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro On Wed, Mar 29, 2017 at 3:33 PM, simran singhal <singhalsimran0@...il.com> wrote: > Use macro min() to get the minimum of two values for brevity and > readability. > > Signed-off-by: simran singhal <singhalsimran0@...il.com> > --- > drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/common/st_sensors/st_sensors_i2c.c b/drivers/iio/common/st_sensors/st_sensors_i2c.c > index c83df4d..7a68fdd 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_i2c.c > +++ b/drivers/iio/common/st_sensors/st_sensors_i2c.c > @@ -39,7 +39,7 @@ static int st_sensors_i2c_read_byte(struct st_sensor_transfer_buffer *tb, > *res_byte = err & 0xff; > > st_accel_i2c_read_byte_error: > - return err < 0 ? err : 0; > + return min(err, 0); > } Appreciate the brevity but this certainly doesn't make code easier to read. In linux kernel err < 0 signifies an error and be replacing comparison < 0 with min() we some hide the meaning of this. thanks, Daniel.
Powered by blists - more mailing lists