linux-kernel - Re: [PATCH v2] staging: iio: Remove unneeded parentheses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ACE88E5-E497-420B-B7EB-4830F129B394@jic23.retrosnub.co.uk>
Date:   Wed, 29 Mar 2017 17:27:43 +0100
From:   Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:     Arushi Singhal <arushisinghal19971997@...il.com>, lars@...afoo.de
CC:     outreachy-kernel@...glegroups.com,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: iio: Remove unneeded parentheses.



On 29 March 2017 17:05:51 BST, Arushi Singhal <arushisinghal19971997@...il.com> wrote:
>Remove the extra parenthesis remove the checkpatch issue.
>
>Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>

Patch doesn't need resending as already applied.
If it did the description is now incorrect!
>---
>changes in v2
> -done the changes according to the current tree
>
> drivers/staging/iio/cdc/ad7746.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/staging/iio/cdc/ad7746.c
>b/drivers/staging/iio/cdc/ad7746.c
>index c2c8aa5585e4..7fa9913386f5 100644
>--- a/drivers/staging/iio/cdc/ad7746.c
>+++ b/drivers/staging/iio/cdc/ad7746.c
>@@ -45,10 +45,10 @@
> #define AD7746_STATUS_RDYCAP		BIT(0)
> 
>/* Capacitive Channel Setup Register Bit Designations
>(AD7746_REG_CAP_SETUP) */
>-#define AD7746_CAPSETUP_CAPEN		(1 << 7)
>-#define AD7746_CAPSETUP_CIN2		(1 << 6) /* AD7746 only */
>-#define AD7746_CAPSETUP_CAPDIFF		(1 << 5)
>-#define AD7746_CAPSETUP_CACHOP		(1 << 0)
>+#define AD7746_CAPSETUP_CAPEN		BIT(7)
>+#define AD7746_CAPSETUP_CIN2		BIT(6) /* AD7746 only */
>+#define AD7746_CAPSETUP_CAPDIFF		BIT(5)
>+#define AD7746_CAPSETUP_CACHOP		BIT(0)
> 
>/* Voltage/Temperature Setup Register Bit Designations
>(AD7746_REG_VT_SETUP) */
> #define AD7746_VTSETUP_VTEN		(1 << 7)
>@@ -56,9 +56,9 @@
> #define AD7746_VTSETUP_VTMD_EXT_TEMP	(1 << 5)
> #define AD7746_VTSETUP_VTMD_VDD_MON	(2 << 5)
> #define AD7746_VTSETUP_VTMD_EXT_VIN	(3 << 5)
>-#define AD7746_VTSETUP_EXTREF		(1 << 4)
>-#define AD7746_VTSETUP_VTSHORT		(1 << 1)
>-#define AD7746_VTSETUP_VTCHOP		(1 << 0)
>+#define AD7746_VTSETUP_EXTREF		BIT(4)
>+#define AD7746_VTSETUP_VTSHORT		BIT(1)
>+#define AD7746_VTSETUP_VTCHOP		BIT(0)
> 
>/* Excitation Setup Register Bit Designations (AD7746_REG_EXC_SETUP) */
> #define AD7746_EXCSETUP_CLKCTRL		BIT(7)
>@@ -82,7 +82,7 @@
> #define AD7746_CONF_MODE_GAIN_CAL	(6 << 0)
> 
> /* CAPDAC Register Bit Designations (AD7746_REG_CAPDACx) */
>-#define AD7746_CAPDAC_DACEN		(1 << 7)
>+#define AD7746_CAPDAC_DACEN		BIT(7)
> #define AD7746_CAPDAC_DACP(x)		((x) & 0x7F)
> 
> /*

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.