linux-kernel - Re: [PATCH] ACPI / gpio: do not fall back to parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8eb1f4c1-61b2-1670-9ee2-086e2ea15cda@redhat.com>
Date:   Wed, 29 Mar 2017 18:33:22 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / gpio: do not fall back to parsing _CRS when we get
 a deferral

HI,

On 28-03-17 17:04, Andy Shevchenko wrote:
> On Thu, 2017-03-23 at 13:21 -0700, Dmitry Torokhov wrote:
>> If, while locating GPIOs by name, we get probe deferral, we should
>> immediately report it to caller rather than trying to fall back to
>> parsing
>> unnamed GPIOs from _CRS block.
>
> +Cc: Hans.
>
> Hans, do have any objections on this? Would you ideally give your
> Tested-by?

Looks good to me and also does not seem to break anything on my test
devices, so:

Acked-and-Tested-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


>
>>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> ---
>>  drivers/gpio/gpiolib-acpi.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
>> index a3faefa44f68..d3f9f028a37b 100644
>> --- a/drivers/gpio/gpiolib-acpi.c
>> +++ b/drivers/gpio/gpiolib-acpi.c
>> @@ -572,8 +572,10 @@ struct gpio_desc *acpi_find_gpio(struct device
>> *dev,
>>  		}
>>
>>  		desc = acpi_get_gpiod_by_index(adev, propname, idx,
>> &info);
>> -		if (!IS_ERR(desc) || (PTR_ERR(desc) ==
>> -EPROBE_DEFER))
>> +		if (!IS_ERR(desc))
>>  			break;
>> +		if (PTR_ERR(desc) == -EPROBE_DEFER)
>> +			return ERR_CAST(desc);
>>  	}
>>
>>  	/* Then from plain _CRS GPIOs */
>> --
>> 2.12.1.500.gab5fba24ee-goog
>>
>>
>