linux-kernel - Re: [PATCH 2/8] platform/x86: fujitsu-laptop: switch to a managed backlight input device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170329195804.GD15472@localhost.localdomain>
Date:   Wed, 29 Mar 2017 12:58:04 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Michał Kępień <kernel@...pniu.pl>
Cc:     Jonathan Woithe <jwoithe@...t42.net>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] platform/x86: fujitsu-laptop: switch to a managed
 backlight input device

On Mon, Mar 20, 2017 at 10:32:18AM +0100, Michał Kępień wrote:
> Use a managed input device for brightness events in order to simplify
> two error paths and one cleanup function while also reducing the number
> of local variables required.  Remove double assignment to make
> checkpatch happy.
> 
> Signed-off-by: Michał Kępień <kernel@...pniu.pl>


And this one mostly addresses my commentary on 1/8.

-- 
Darren Hart
VMware Open Source Technology Center