lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Mar 2017 13:12:39 -0700 From: Darren Hart <dvhart@...radead.org> To: Michał Kępień <kernel@...pniu.pl> Cc: Jonathan Woithe <jwoithe@...t42.net>, Andy Shevchenko <andy@...radead.org>, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/8] platform/x86: fujitsu-laptop: move hotkey input device setup to a separate function On Mon, Mar 20, 2017 at 10:32:20AM +0100, Michał Kępień wrote: > Simplify error handling in acpi_fujitsu_laptop_add() by moving code > responsible for setting up the input device to a separate function. > > Signed-off-by: Michał Kępień <kernel@...pniu.pl> > --- > drivers/platform/x86/fujitsu-laptop.c | 74 ++++++++++++++++++++--------------- > 1 file changed, 43 insertions(+), 31 deletions(-) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index 3483ac37bee5..b1a08d83330b 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -794,7 +834,6 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device) > { > int result = 0; > int state = 0; > - struct input_dev *input; > int error; This patch highlights the odd error handling / return path with the odd mix of result and error. Not introduced here, but something for a future cleanup perhaps. -- Darren Hart VMware Open Source Technology Center
Powered by blists - more mailing lists