linux-kernel - Re: [PATCH v1] x86/platform/intel-mid: Enable bluetooth on Intel Edison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170330095448.GA15232@gmail.com>
Date:   Thu, 30 Mar 2017 11:54:48 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] x86/platform/intel-mid: Enable bluetooth on Intel
 Edison


* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Thu, 2017-03-30 at 09:23 +0200, Ingo Molnar wrote:
> > * Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > 
> > > Intel Edison has Wi-Fi + BT module attached and, since it's an SFI-
> > > enumerated
> > > platform, needs a platform data. Here we add bits to enable
> > > bluetooth device.
> 
> > > +
> > > +static struct gpiod_lookup_table tng_bt_sfi_gpio_table = {
> > > +	.dev_id	= "hci_bcm",
> > > +	.table	= {
> > > +		GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
> > > GPIO_ACTIVE_HIGH),
> > > +		GPIO_LOOKUP("0000:00:0c.0", -1, "shutdown",
> > > GPIO_ACTIVE_HIGH),
> > > +		GPIO_LOOKUP("0000:00:0c.0", -1, "host-wakeup",
> > > GPIO_ACTIVE_HIGH),
> > 
> > Minor nit: just out of general principle (because the rest of the code
> > looks so 
> > nice) I'd properly tabulate the last column as well - something like:
> > 
> > 		GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
> > GPIO_ACTIVE_HIGH),
> > 		GPIO_LOOKUP("0000:00:0c.0", -1,
> > "shutdown",      GPIO_ACTIVE_HIGH),
> > 		GPIO_LOOKUP("0000:00:0c.0", -1, "host-
> > wakeup",   GPIO_ACTIVE_HIGH),
> > 
> > Formatted that way the reviewer's eye can skip over those values in
> > 100 
> > milliseconds, determining that all 3 values are GPIO_ACTIVE_HIGH.
> 
> Thanks for a hint.
> Should I resend it?

Yeah, please send a v2.

Thanks!

	Ingo