linux-kernel - Re: [PATCH v1] x86/platform/intel-mid: Enable bluetooth on Intel Edison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 13:34:57 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] x86/platform/intel-mid: Enable bluetooth on Intel Edison

On Thu, Mar 30, 2017 at 12:54 PM, Ingo Molnar <mingo@...nel.org> wrote:

>> > Minor nit: just out of general principle (because the rest of the code
>> > looks so
>> > nice) I'd properly tabulate the last column as well - something like:
>> >
>> >             GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
>> > GPIO_ACTIVE_HIGH),
>> >             GPIO_LOOKUP("0000:00:0c.0", -1,
>> > "shutdown",      GPIO_ACTIVE_HIGH),
>> >             GPIO_LOOKUP("0000:00:0c.0", -1, "host-
>> > wakeup",   GPIO_ACTIVE_HIGH),
>> >
>> > Formatted that way the reviewer's eye can skip over those values in
>> > 100
>> > milliseconds, determining that all 3 values are GPIO_ACTIVE_HIGH.
>>
>> Thanks for a hint.
>> Should I resend it?
>
> Yeah, please send a v2.

Sent and just noticed I forgot to increase version number.

-- 
With Best Regards,
Andy Shevchenko