linux-kernel - Re: [PATCH linux-next v2 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 13:38:34 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     cristian.birsan@...rochip.com, nicolas.ferre@...el.com,
        gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     ludovic.desroches@...el.com, alexandre.belloni@...e-electrons.com,
        boris.brezillon@...e-electrons.com,
        Cristian Birsan <cristian.birsan@...rochip.com>
Subject: Re: [PATCH linux-next v2 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree


Hi,

cristian.birsan@...rochip.com writes:
> From: Cristian Birsan <cristian.birsan@...rochip.com>
>
> Check fifo configuration values against device tree values for endpoint fifo
> in auto configuration mode (fifo_mode=0).
>
> Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2035906b..3fd43fb 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2118,14 +2118,34 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>  			dev_err(&pdev->dev, "of_probe: fifo-size error(%d)\n", ret);
>  			goto err;
>  		}
> -		ep->fifo_size = fifo_mode ? udc->fifo_cfg[i].fifo_size : val;
> +		if (fifo_mode) {
> +			if (val < udc->fifo_cfg[i].fifo_size) {
> +				dev_warn(&pdev->dev,
> +					 "of_probe: fifo-size table value not supported by HW, using DT value\n");

114 characters long. Is this even worth a warning? probably not.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)