lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Mar 2017 20:06:18 +0200 From: jacopo <jacopo@...ndi.org> To: Alexandre Belloni <alexandre.belloni@...e-electrons.com> Cc: Arushi Singhal <arushisinghal19971997@...il.com>, outreachy-kernel@...glegroups.com, Jonathan Cameron <jic23@...nel.org>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] iio: adc: replace comma with a semicolon Hi Alexandre hope you're doing good! On Thu, Mar 30, 2017 at 07:23:12PM +0200, Alexandre Belloni wrote: > On 30/03/2017 at 15:30:46 +0200, jacopo wrote: > > Hi Arushi, > > thanks for your patch > > > > On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > > > Replace a comma between expression statements by a semicolon. This > > > changes the semantics of the code, but given the current indentation > > > appears to be what is intended. > > > A simplified version of the Coccinelle semantic patch that performs this > > > transformation is as follows: > > > > > > // <smpl> > > > @r@ > > > expression e1,e2; > > > @@ > > > > > > e1 > > > -, > > > +; > > > e2; > > > // </smpl> > > > > > > > You can simply say that this fixes what appears to be a bug to me. > > I wonder how this does even compile.. > > > > It is not a bug, it is perfectly valid and working as expected/intended. > This is just a cosmetic change. > > See https://en.wikipedia.org/wiki/Comma_operator if you want to > understand. > Thanks! That's valid and legal (I should have thought at multiple expression in for(;;) as an example). Ignore my comment then (I still don't think it was "intended" as it's quite unusual to see commas there :) Thanks j > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Powered by blists - more mailing lists