linux-kernel - Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170330.110728.1080980088987923914.davem@davemloft.net>
Date:   Thu, 30 Mar 2017 11:07:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     jhansen@...are.com, mst@...hat.com, aditr@...are.com,
        georgezhang@...are.com, stefanha@...hat.com, julia.lawall@...6.fr,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on
 return value

From: Colin King <colin.king@...onical.com>
Date: Wed, 29 Mar 2017 16:33:55 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Rather than assign the positive errno values to ret and then
> checking if it is positive and flip the sign, just return the
> errno value.
> 
> Detected by CoverityScan, CID#986649 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to net-next, thanks.