linux-kernel - Re: [PATCH] drivers: iio: replace comma with a semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Mar 2017 19:16:51 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH] drivers: iio: replace comma with a semicolon

On 30/03/17 13:41, Arushi Singhal wrote:
> Replace a comma between expression statements by a semicolon. This
> changes the semantics of the code, but given the current indentation
> appears to be what is intended.
> A simplified version of the Coccinelle semantic patch that performs this
> transformation is as follows:
> 
> // <smpl>
> @r@
> expression e1,e2;
> @@
> 
>  e1
> -,
> +;
>  e2;
> // </smpl>
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
As per the discussion about the other one.  This is perfectly
correct, but weird enough that I think we'll clear it out.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

I did add chemical to the title though to make it clearer what
this was covering.

Thanks,

Jonathan
> ---
>  drivers/iio/chemical/ams-iaq-core.c | 2 +-
>  drivers/iio/chemical/vz89x.c        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/chemical/ams-iaq-core.c b/drivers/iio/chemical/ams-iaq-core.c
> index 41a8e6f2e31d..c948ad2ee9ad 100644
> --- a/drivers/iio/chemical/ams-iaq-core.c
> +++ b/drivers/iio/chemical/ams-iaq-core.c
> @@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client *client,
>  	mutex_init(&data->lock);
>  
>  	indio_dev->dev.parent = &client->dev;
> -	indio_dev->info = &ams_iaqcore_info,
> +	indio_dev->info = &ams_iaqcore_info;
>  	indio_dev->name = dev_name(&client->dev);
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  
> diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> index 8e0e4415c161..f75eea6822f2 100644
> --- a/drivers/iio/chemical/vz89x.c
> +++ b/drivers/iio/chemical/vz89x.c
> @@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
>  	mutex_init(&data->lock);
>  
>  	indio_dev->dev.parent = &client->dev;
> -	indio_dev->info = &vz89x_info,
> +	indio_dev->info = &vz89x_info;
>  	indio_dev->name = dev_name(&client->dev);
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  
>