linux-kernel - Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFquGSgK7tkYDpkJM7C7JChZMqvmHoJyiLE9_ZG4CGBOSw@mail.gmail.com>
Date:   Fri, 31 Mar 2017 13:11:59 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Sergio Prado <sergio.prado@...abworks.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "ben-linux@...ff.org" <ben-linux@...ff.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree

On 31 March 2017 at 09:25, Arnd Bergmann <arnd@...db.de> wrote:
> On Sat, Mar 18, 2017 at 2:13 AM, Sergio Prado
> <sergio.prado@...abworks.com> wrote:
>
>>
>> +static const struct of_device_id s3cmci_dt_match[] = {
>> +       {
>> +               .compatible = "samsung,s3c2410-sdi",
>> +               .data = (void *)0,
>> +       },
>> +       {
>> +               .compatible = "samsung,s3c2412-sdi",
>> +               .data = (void *)1,
>> +       },
>> +       {
>> +               .compatible = "samsung,s3c2440-sdi",
>> +               .data = (void *)1,
>> +       },
>> +       { /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match);
>> +
>
> The names don't match:
>
> In file included from /git/arm-soc/drivers/mmc/host/s3cmci.c:14:0:
> /git/arm-soc/drivers/mmc/host/s3cmci.c:1844:25: error:
> 'sdhci_s3c_dt_match' undeclared here (not in a function); did you mean
> 's3cmci_dt_match'?
>  MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match);
>                          ^
> /git/arm-soc/include/linux/module.h:212:21: note: in definition of
> macro 'MODULE_DEVICE_TABLE'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                      ^~~~
> /git/arm-soc/include/linux/module.h:212:27: error:
> '__mod_of__sdhci_s3c_dt_match_device_table' aliased to undefined
> symbol 'sdhci_s3c_dt_match'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                            ^
> /git/arm-soc/drivers/mmc/host/s3cmci.c:1844:1: note: in expansion of
> macro 'MODULE_DEVICE_TABLE'
>  MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match);
>  ^~~~~~~~~~~~~~~~~~~
> /git/arm-soc/scripts/Makefile.build:314: recipe for target
> 'drivers/mmc/host/s3cmci.o' failed
>
> Can you send a fix?

Never mind, I am dropping the patches from my next branch as those
clearly haven't been built/tested by Sergio properly. It's better that
he re-spins them.

Arnd, thanks for reporting and even fixing some of the problems!

Kind regards
Uffe