linux-kernel - Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170331193920.030d9ca8@gmail.com>
Date:   Fri, 31 Mar 2017 19:39:20 +0200
From:   Ralph Sennhauser <ralph.sennhauser@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Jason Cooper <jason@...edaemon.net>,
        Gregory Clement <gregory.clement@...e-electrons.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes

On Fri, 31 Mar 2017 18:50:15 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> > -			sata@...00 {
> > +			satac0: sata@...00 {  
> 
> Hi Ralph
> 
> Why the c in satac0?

For controller and to not conflict with a use case of sata0 for a port,
similarly to pciec and pcie1. See armada-385-synology-ds116.dts.

> 
> >  
> > -			usb3@...00 {
> > +			usb3_0: usb3@...00 {
> >  				compatible =
> > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 0x4000>;
> >  				interrupts = <GIC_SPI 16
> > IRQ_TYPE_LEVEL_HIGH>; @@ -598,7 +598,7 @@
> >  				status = "disabled";
> >  			};
> >  
> > -			usb3@...00 {
> > +			usb3_1: usb3@...00 {
> >  				compatible =
> > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 0x4000>;
> >  				interrupts = <GIC_SPI 17
> > IRQ_TYPE_LEVEL_HIGH>;  
> 
> I can understand what you are saying. But does anybody else care? Are
> there other .dtsi files differentiating between USB 1.1, 2 and 3?

It's handled differently where ever I looked, some do some don't. A
case for distinguishing USB 2.0 and USB 3.0 like this is
armada-388-gp.dts.

Personally I'm only interested in there being a label, making it
"natural" is a bonus though.

Thanks
Ralph

> 
>       Andrew