[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1491017626.27353.31.camel@perches.com>
Date: Fri, 31 Mar 2017 20:33:46 -0700
From: Joe Perches <joe@...ches.com>
To: Chewie Lin <linsh@...gonstate.edu>
Cc: Randy Dunlap <rdunlap@...radead.org>, greg@...ah.com,
forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch
warning
On Fri, 2017-03-31 at 20:18 -0700, Chewie Lin wrote:
> These are good points, but any feedback on the dev_warn() call itself?
> I was trying to fix the checkpatch warning on my first try.
Using "%s" with a long string is generally inefficient.
Compare the compiled object size of
printf("%s is %d\n", "Long string", 1);
to
printf("Long string is %d\n", 1);
Powered by blists - more mailing lists